Skip to content

CLOUDSTACK-10255: Fix agent logrotate#2429

Merged
yadvr merged 1 commit intoapache:4.11from
nuagenetworks:bugfix/CLOUDSTACK-10255
Jan 24, 2018
Merged

CLOUDSTACK-10255: Fix agent logrotate#2429
yadvr merged 1 commit intoapache:4.11from
nuagenetworks:bugfix/CLOUDSTACK-10255

Conversation

@fmaximus
Copy link
Contributor

@fmaximus fmaximus commented Jan 24, 2018

Renamed cloudstack-agent.logrotate to cloudstack-agent.logrotate.in,
so Ant will run the filterchain while copying.
This made the ant run copy block of cloudstack-agent.logrotate unnecessary,
so this is removed.

@fmaximus fmaximus requested a review from yadvr January 24, 2018 12:29
@fmaximus fmaximus changed the base branch from master to 4.11 January 24, 2018 12:29
sgoeminn
sgoeminn approved these changes Jan 24, 2018
View reviewed changes
Copy link
Contributor

@sgoeminn sgoeminn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed internally, LGTM!

@yadvr yadvr added this to the 4.11.1 milestone Jan 24, 2018
DaanHoogland
DaanHoogland approved these changes Jan 24, 2018
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no harm here

@yadvr
Copy link
Member

yadvr commented Jan 24, 2018

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jan 24, 2018

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 24, 2018

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-1679

@yadvr
Copy link
Member

yadvr commented Jan 24, 2018

@blueorangutan test

@yadvr yadvr modified the milestones: 4.11.1, 4.11.0 Jan 24, 2018
@blueorangutan
Copy link

blueorangutan commented Jan 24, 2018

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@yadvr
Copy link
Member

yadvr commented Jan 24, 2018

Since this is packaging related issue, clearly causing failures on logrotation we can consider this towards 4.11.0 milestone. /cc @DaanHoogland @wido @rafaelweingartner @borisstoyanov and others.

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 24, 2018

4.11.0 i concur

@yadvr
Copy link
Member

yadvr commented Jan 24, 2018

Okay, will move it to 4.11.0 milestone.

yadvr
yadvr approved these changes Jan 24, 2018
View reviewed changes
Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@blueorangutan
Copy link

blueorangutan commented Jan 24, 2018

Trillian test result (tid-2190)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 21245 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2429-t2190-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Smoke tests completed. 67 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@yadvr yadvr merged commit 22d6718 into apache:4.11 Jan 24, 2018
yadvr added a commit to shapeblue/cloudstack that referenced this pull request Jan 26, 2018
@yadvr
Merge branch '4.11'
d6ce39b 
- CLOUDSTACK-10239: Fallback to default provider if needed (apache#2430)
- CLOUDSTACK-10255: Fix agent logrotate (apache#2429)
@Slair1 Slair1 mentioned this pull request Mar 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

+1 more reviewer

@sgoeminn sgoeminn sgoeminn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

component:packaging type:bug

Projects

None yet

Milestone

4.11.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@fmaximus @yadvr @blueorangutan @DaanHoogland @sgoeminn